WEI Xikai

Results 63 comments of WEI Xikai

It seems this condition is wrong(https://github.com/buraksezer/consistent/blob/master/consistent.go#L163): ``` if count >= len(c.sortedSet) { ``` Is it reanable to remove equal?: ``` if count > len(c.sortedSet) { ```

I have checked the definition of variables in `consistent.Config` but I still can't understand why the case is wrong: ``` cfg := consistent.Config{ PartitionCount: 1, ReplicationFactor: 1, Load: 1, Hasher:...

@waynexia 👍 I can't agree more with this proposal.

During the development, I find it is hard to combine the `VolatileCatalog` and `Cluster` because create/drop/open/close procedures are too complex to be processed by the combined module in cluster mode,...

#270 will fix this. The reason for this bug is that the test data won't be cleaned before any run, while the table id is auto-incremented, so the created, dropped,...

> I think of one corner case even when #270 is merged > > > if users drop a new table in `00_dummy`, then all table id after `00_dummy` will...

I guess #270 has fixed this, so let's close it.

It is great if `Date` is supported, and we can leave this feature for volunteers in the community.

> I am try. pls assign me. The proposal is a little bit simple, and any discussion is welcome when you have any difficulty in implementing this feature.

It's a very useful feature, and we will support it in the near future.