Shane-Donlon

Results 7 comments of Shane-Donlon

Hey Wout, Just came across this PR this morning. Excerpt URL from Windows OS. There's an extra `src` (`%2Fsrc%2F`) in here which is causing it to fail. If I remote...

Hey Wout, a little bit of digging around. Seems the problem was with string concatenation on the fetch request. [https://github.com/QwikDev/qwik/blob/main/packages/qwik/src/optimizer/src/plugins/click-to-component.html#L151](https://github.com/QwikDev/qwik/blob/main/packages/qwik/src/optimizer/src/plugins/click-to-component.html#L151) ![image](https://github.com/user-attachments/assets/07405a38-bfc6-44f9-8cbd-9229695fa259) Possible edit: Works fine on Windows (full disclosure haven't...

> Hmm ok I'll take a look. I'm not really liking that workaround, it's complex and we don't know where else things are failing Yeah I get that. Although the...

Salut Maïeul, ce va? (my French is very rusty) So I think I've solved some of the bugs from the qwik-themes repo. I did fork it, but I disconnected the...

@maiieul Salut Maïeul, ce va? Okay so I think (famous last words 🤣 ) I've fixed the bugs and moved away from useVisibleTask. Testing site link: [https://testing-qwik-themes-v-103.netlify.app/](https://testing-qwik-themes-v-103.netlify.app/) Repo Link: [https://github.com/Shane-Donlon/qwik-themes](https://github.com/Shane-Donlon/qwik-themes)...

Hey Wout, I cannot seem to find the original message anymore, so unsure what the original issue was. Slim chance, but worth asking, any ideas what this could have been?...

Remaining to-do: - [x] improve warning message with feedback from Wout above. - [x] add stop propagation - [x] add tests for stop propagation I was away last week and...