Shadowth117

Results 12 comments of Shadowth117

# Vita3K summary Version: v0.1.9 Build number: 3525 Commit hash: [Vita3K/Vita3K@d942cf20](https://github.com/Vita3K/Vita3K/commit/d942cf20) CPU backend: Dynamic # Test environment summary Tested by: Shadowth117 OS: Windows 10 CPU: AMD Ryzen 9 5900X GPU:...

Are you sure on this one? It does look at least look like the ability and move are configured correctly already. https://github.com/pagefaultgames/pokerogue/blob/33f8365192f49d8ad3448e54afa1b76d48ef3910/src/data/ability.ts#L3733 https://github.com/pagefaultgames/pokerogue/blob/33f8365192f49d8ad3448e54afa1b76d48ef3910/src/data/move.ts#L6585

> Actually on second thought, PostKnockOut might not be the right attr Which would you use instead? Previously Soul Heart was using Post Knockout, but that appears to be wrong...

> This will not work. PostKnockOut is called for every pokemon that is alive on the battlefield when fainting occurs. This is what currently happens on your branch. > >...

Okay, I think the new commit should be what we want, after testing it a bit. I ended up adding the attacker to postknockout and splitting it to an any...

I've gone ahead and made a PR for this. It's something I saw too while playing.

I verified and went ahead and made a pull request for this. https://github.com/pagefaultgames/pokerogue/pull/1233

Someone did more of an overhaul to that setup for supreme overlord and so this is probably the go forward pr from here: https://github.com/pagefaultgames/pokerogue/pull/1219

> Already done in #1219 The other PR integrates it nicely so I think I can just close this then.

Whoever works on this should account for sleep talk, since that should bypass the sleep check.