Shabir Mohamed Abdul Samadh

Results 51 comments of Shabir Mohamed Abdul Samadh

I agree with @willnorris. Unless the requirement is a clear need (for the purposes of the license to be valid), we should avoid overloading the tool. It is definitely a...

Thank you very much for the samples @Sita04 , these looks great 😃 Just a few thoughts: - I see that there are multiple different actions that are part of...

@averikitsch can you review my comments? I think I still need someone reviewing my reviews

> Thank you @Shabirmean, one minor comment. Thank you for the quick review @yuwenma. Sorry, but I am not seeing any comments. Did you want me to look into something?

@NimJay - thank you for outlining the options above. All great suggestions I agree with you on **Option-1**. It might not be worth the investment to take on all that...

Potential improvement to the fix, [link to the guide](https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/docs/gcp-instrumentation.md) in comments.

This issue might not be relavant with the Cloud Debugger sunset being announced as explained in #836

> Worth mentioning: This issue sounds similar to [GoogleCloudPlatform/anthos-samples#54](https://github.com/GoogleCloudPlatform/anthos-samples/issues/54). > The cause of the problem in [GoogleCloudPlatform/anthos-samples#54](https://github.com/GoogleCloudPlatform/anthos-samples/issues/54) was the use of GitHub secrets for environment variables. > > @Shabirmean, correct...

According to the profiler data for the `currencyservice` and `serviceservice` the `request-retry` package is the one that seems to be using a lot of memory. It is imported by the...

So the issue clearly seems like it's with any library that uses `google-cloud/common`. In our case `google-cloud/debug` and `google-cloud/tracing`. See the memory graphs for the [four cases](https://github.com/GoogleCloudPlatform/microservices-demo/issues/538#issuecomment-980392590) described in the...