Shahbaz Youssefi

Bug adding large whitespace before `)` (and then remove on second format)

4

Take this change in ANGLE: https://chromium-review.googlesource.com/c/angle/angle/+/2807780 When running `$ git cl format` (from depot tools), it produces the following change: ``` src/libANGLE/renderer/metal/gen_mtl_format_table.py: - !display->getFeatures().forceD24S8AsUnsupported.enabled") + !display->getFeatures().forceD24S8AsUnsupported.enabled" ) ``` Running `git...

Input attachments shown with LOAD DONT CARE despite loadOp=LOAD

1

## Description Take the following framebuffer: - Attachment 0 MSAA loadOp=DONT_CARE, storeOp= DONT_CARE - Attachment 1 loadOp=LOAD, storeOp=STORE - Subpass 0: * Color Attachment 0: Attachment 0 * Input Attachment...

Please consider adding a feature to add a halo around the mouse pointer

1

Awesome piece of software! One missing feature is accenting the mouse pointer (always, or on events, like click). That helps tremendously to bring to attention of the viewer where the...

Precision of image is applied to result of imageLoad when generating SPIR-V

1

Take the following code: ```c #version 320 es layout(set = 0, binding = 0, rgba8) uniform readonly mediump image2D img; layout(set = 0, binding = 1) buffer B { vec4...

Should `NoContraction` apply to `dot()`?

2

The code [looks like][1] it means to apply `NoContraction` on `dot()`, but doesn't actually. Test case: [1]: https://github.com/KhronosGroup/glslang/blob/master/glslang/MachineIndependent/propagateNoContraction.cpp#L178 ``` #version 450 core precise gl_Position; float u; void main() { vec4...

glslang doesn't apply `NoContraction` through struct constructors

1

Noticed while implementing a similar algorithm in ANGLE. Take the following shader: ```c #version 450 core float u; struct S1 { precise float f; int i; precise vec4 v; mat4...

Noticed while implementing a similar algorithm in ANGLE. Take the following shader: ```c #version 450 core float u; struct S1 { precise float f; int i; precise vec4 v; mat4...

Use VK_EXT_swapchain_maintenance1 in the Swapchain Recreation sample

4

## Description This change builds on https://github.com/KhronosGroup/Vulkan-Samples/pull/613 which adds a sample demonstrating safe recycling of present semaphores and efficient swapchain recreation. This change takes advantage of VK_EXT_swapchain_maintenance1 to perform the...

False positive about fragment output dynamic state when fragment shader is missing

8

Take the following scenario: - Create a library with vertex input - Create a library with vertex shader only - Create a library with fragment output with BLEND_CONSTANTS dynamic state...

Missing swapchain-related semaphore synchronization validation

1

Context: see the commit message and tests added in this ANGLE change: https://chromium-review.googlesource.com/c/angle/angle/+/4194182 A bug was found where ANGLE would acquire a swapchain image, but make a submission without waiting...