Serg

Results 12 comments of Serg

change the order of modalScope destroy

Thanks for this! I was in the middle of finding the issue as well.

On Location Change don't pass event as result

I can see it both ways, however it's possible users of the service have one function for ok/cancel which then uses the function input to decide what to do. In...

If the selected item has an item value that is null then it is not shown

4.9 on my local env.

If the selected item has an item value that is null then it is not shown

Thanks! Would this be a reasonable feature request? If not we should add it to the docs.

If the selected item has an item value that is null then it is not shown

Sure! Can you point me to the area of the code that handles values to get me started?

If the selected item has an item value that is null then it is not shown

Thanks! Will see if I can get a PR out shortly.

Errors in 1.4 API Requests

I've had a PR open for this: https://github.com/imartingraham/nomniture/pull/20

Min Pool is not respected

@sushantdhiman Thank you for the quick reply! There were a couple reasons for this PR attempt: 1. I noticed perf degradations for the initial batch of queries being done as...

Min Pool is not respected

Sorry for the miscommunication, I meant that in 4.x (pre pool) min was respected and Sequelize would make the min configured connections on app start, in 5.x it looked like...

Min Pool is not respected

@marcogrcr I'm sure this was a regression. I know @sushantdhiman had to depart the project, not sure how to get the discussion going with the new maintainers.