Sergei Khlebnikov

Results 10 comments of Sergei Khlebnikov

oops, I think I broke something

Some tests failed. Now I'll see what went wrong

https://github.com/mikependon/RepoDB/blob/9ec4d8e09a711786d58d27ea1d682e3ef90aa01b/RepoDb/RepoDb.Tests/RepoDb.UnitTests/QueryGroups/QueryGroupParseExpressionClassesTest.cs#L25 https://github.com/mikependon/RepoDB/blob/9ec4d8e09a711786d58d27ea1d682e3ef90aa01b/RepoDb/RepoDb.Tests/RepoDb.UnitTests/QueryGroups/QueryGroupParseExpressionClassesTest.cs#L33 I made a dictionary for the mapped names, but there is a duplicate name here. I think that this is not correct, especially considering the old logic FirstOrDefault

Mapping calls the PropertyCache at generation time. Therefore, it cannot be called before the mapping itself. I added a separate cache for mappedNames, which is called for individual properties.

> > > https://github.com/mikependon/RepoDB/blob/9ec4d8e09a711786d58d27ea1d682e3ef90aa01b/RepoDb/RepoDb.Tests/RepoDb.UnitTests/QueryGroups/QueryGroupParseExpressionClassesTest.cs#L25 > > https://github.com/mikependon/RepoDB/blob/9ec4d8e09a711786d58d27ea1d682e3ef90aa01b/RepoDb/RepoDb.Tests/RepoDb.UnitTests/QueryGroups/QueryGroupParseExpressionClassesTest.cs#L33 > > I made a dictionary for the mapped names, but there is a duplicate name here. I think that this is not...

https://github.com/mikependon/RepoDB/blob/9ec4d8e09a711786d58d27ea1d682e3ef90aa01b/RepoDb.Core/RepoDb.Tests/RepoDb.IntegrationTests/PropertyHandlerImplicitTest.cs#L50 PropertyHandler Also calls mappedNames during mapping...

I left the PropertyCache alone. The PropertyHandler logic is designed for the fact that we will iterate over the properties and, accordingly, map them one by one. So I added...

it's high time ;)

Thank you very much for this information. This approach works correctly, but there are limitations. 1) I do not understand if I can set a variable in the Flowchart action...