Hyungjun Seo
Hyungjun Seo
> #2658 is already merged. rebase this. I have completed the rebase.
> FYI) #2658 is from another branch [tanh_gelu](https://github.com/nnstreamer/nntrainer/tree/tanh_gelu) on upstream. Yes, that's right. #2658 has been merged into the main so there is no problem.
> @SeoHyungjun Can we close this issue? I think #2436 resolves this issue. Yes, It was resolved. I closed this issue.
We are going to change to use nnstreamer-windows-resource instead of submodule. I'll fix this PR after the windows-resource repo update.
> > The add and sub layers have almost identical code. How about creating a basic operation class? It would be simple if the add and sub inherited from the...
I think we can create an add layer like this using the operation layer. ```cpp // add_layer.h #pragma once #include "operation_layer.h" namespace nntrainer { class AddLayer : public OperationLayer {...
> Great suggestion @SeoHyungjun ! Upon his suggestion, what about using enum for operation type? If more operations are added, the switch clause may not work only with the first...