Michal Majer
Michal Majer
Just ran into this. Would it be worth it to implement `beforeClose` differently? Maybe add some behavior to `setIsOpen(false)`? The mounting of `` is dependant on `isOpen` after all. The...
Just happened to me. Not even deleting the repo helped. But then I removed `.gitignore` in a parent directory and everything was working again. For full context, the `.gitignore` was:...
Interesting stuff! I agree, I just wanted the diagnostic to not be on by default (people have preferences and it could be annoying). So two solutions that come to mind...
I am happy to say that I made progress on the VS Code situation. First of all, the import organizing does work with `editor.codeActionsOnSave` setting: https://github.com/user-attachments/assets/a11379e6-0e01-42d6-84c4-90cd90cd40c7 But as you pointed...
Moving aliases to the right group has been implemented. I went for grouping based on the parent import: ```zig const abc = @import("abc.zig"); const abc_related = abc.related; const abc_related2 =...
Thanks for collaborating and taking the time to teach me more about Zig! The followup tasks would need some benchmarking (never optimize blindly). Do you have a recommended microbenchmark setup...
Great success! Bench - reproduced results ```bash ❯ poop zig-out/bin/bench-orig zig-out/bin/bench-techatrix Benchmark 1 (3 runs): zig-out/bin/bench-orig measurement mean ± σ min … max outliers delta wall_time 95.0s ± 2.43s 93.4s...
I should have read the comment above more carefully. Here is my full process for using `zig fetch`: 1. Fetch using zig ```bash zig fetch --save=ecs git+https://github.com/prime31/zig-ecs ``` This should...
I think I got to the root of this. The cause is caching of the node types ([link to code](https://github.com/zigtools/zls/blob/93b7bbd0d96ee7088c46d1373a2810e84f7d47be/src/analysis.zig#L1235C5-L1235C83)). The cache does not take into account the fact that...
Another observation: the reason why hover works most of the time is because the `Analyser` is instantiated for each request (with clean cache). So this bug can happen on hover...