Sefiraat

Results 65 comments of Sefiraat

> This feels like unnecessary weight in my opinion. Why not add a default method to `EnergyComponent` like `sendMultimeterInfo(Player player, Location location)`, move the stuff for the default message there...

Comment from the previous PR I'm closing: So, near as I can tell, the 5th branch (line 280) is never called by items moving through cargo though it will be...

I have added the check to both the SlimefunItemStack/SlimefunItemStack branch and to the ItemStack/SlimefunItemStack branches which should now cover all possible routes

> First thoughts: This is an interesting PR and I understand the reasoning why. I have a few questions however: > > 1. Do you believe this is better than...

> Pretty much looking good to me, thank you! > > Although a part of me wished glow berry juice gave night vision XD I was going to say it...

Personally I am in favour of what @Sfiguz7 mentioned on Discord, changing/overloading the SlimefunItemStack constructor to allow for multiple PotionEffects. Then perhaps all give a basic level of saturation and...

I have just tested this with my DankPacks from dt2 and they are effected in the same way. SlimeTinker tools/repair kits would likely be effected if they were itemstacks that...

Uhm, I might be a big dummy but something in SlimefunItem like boolean enforceLoreCheck that defaults false and have cargo check this then only do the previous/extended check as/when told...

Ah. I could probably have rechargeable extend Distinct and the scoop is limited use so I could make limited-use implement distinct also? I’ll modify when I get home

While this will likely need sorting, as bundles are not yet officially release and not due until 1.19 I'm not sure this would benefit from being looked into yet as,...