Sébastien Monterisi comments

Results 51 comments of


                                            Sébastien Monterisi

update architecture/intro page with adr-14

Since ADR is not accepted, this issue may deserves to be closed.

add an option to create a hook on fop:modules:hook (register a hook on a module)

Not creating it prevents typo, it's good for safety imo.

add an option to create a hook on fop:modules:hook (register a hook on a module)

yes, that will be more user friendly :)

Fix "employee" option not found

I didn't test, but lgtm.

Add command to desactive / active all or a specific override

maybe. Are someone really interested by this command ? @okom3pom , still interested by this feature ? Should we keep this issue open ?

Split Maintenance commands

actions are : - get shop maintenance status - set shop maintenance status - get shop maintenance ip - set shop maintenance ip

Avoid using default db prefix `ps_`

anybody with database access, it could also process a `SHOW TABLES;` request and find them. If the attacker can only perform queries without retrieving results, it could also try some...

Avoid using default db prefix `ps_`

So in brief, with module with vulnerability, having a different prefix is a security. ✅ We should add a notice or maybe better, a link to good practices to secure...

fix security : update node js dependencies

I tried with an action that merges the dependabot PR but it doesn't work on public repo anymore :/

Cron tasks not running

As now, I just wanted to checked if the cronjobs in the ps admin is registred in the prestashop cronjob webservice, but there is no documentation api available ... Please...