Sébastien Monterisi comments

Results 51 comments of


                                            Sébastien Monterisi

Database cart optimizer

@TheoAlloin Please provide a description of this PR. You must also fix the style : run 'composer run-script fop_check` or `vendor/bin/php-cs-fixer fix` then push to this repo.

Database cart optimizer

@TheoAlloin You can also merge dev into your branch then resolve conflicts.

Cart rules optimizer

Thanks for contributing :) You are welcome. We'll review your PR as soon as possible ... (in a few, days or weeks...)

Cart rules optimizer

ping @TheoAlloin . J'ai fais pas mal de remarques, qu'en penses-tu ?

Cart rules optimizer

Tu sais, j'ai donné de mon temps pour faire cette review @TheoAlloin ça serait gentil de donner un signe de vie ...

Squash commit ?

you mean, squash all the commits from dev into a single one when merging dev into master ? What's the real problem ?

Squash commit ?

Ah, oui, oki 🙂. C'est une recommandation qui pourrait rentrer dans des recommandations de dev. Dans le fichier Contributing ?

add database cleaner

ping @TheoAlloin . Ton retour est le bienvenu ici aussi.

Add a command to purge old logs

Good idea. I'm in need for this feature. With option to act on levels under a specified argument. `fop:clear-log --under-level 3` : remove all logs of levels 1,2 and 3....

DevTool : command to generate Class name, service name from a command name.

Not really sure, this is needed, we'll see while folks write a new command...