AppleTheGolden
AppleTheGolden
Hmm, haven't tested it with sounds that happen while minimized. I'll try it out, and report back.
Tested it: unfortunately, sounds can still *start* after all channels are paused. The SoundSystem doesn't keep track of whether it's paused, calling pauseAll just iterates over all sound sources and...
In that case, we could avoid the whole mess by cirumventing the volume == 0 -> stop soundsystem check entirely by not calling SoundManager#updateSoundVolume, but SoundSystem#updateSoundVolume, a method i only...
Well, it... works? However, there are even more checks to see if volume == 0, so sounds will never be started if the master volume is zero, i.e. when minimized....
I'd argue that by default it shouldn't be at exactly 0%, because it's not obvious that this mod causes music to be stopped, especially given that the mod is called...
> Huh, the default should be 25% volume when unfocused, 0% only when entirely hidden (e.g. minimized). Is that not the case for you? Ah, yeah, it does work like...
> As for the other issue, I'm not really comfortable having the default be to reduce sound to a technically inaudible level because it feels super dirty to have it...
Duplicate of #3411
Note that Webhooks cannot send replies.
For anyone else stumbling over this problem, here's the simplest patch I could come up with that just disables the renaming. Will break generating chapter titles for epub from folder...