Alexey Ivanov
Alexey Ivanov
rebased ontop of a fixed CI.
Hm... never mind -- seems like I've misused the API: using `NewWithBoundaries` does not automatically adjusts the `splitmask` to be an average of the two (which is not even possible...
Actually, it is not that simple. On a random input it is indeed working fine but if I use a skewed input then output chunk sizes are heavily skewed towards...
Is it possible to change it to either: ``` bits.TrailingZeros64(digest) == c.averageBits ``` or a more gentle: ``` (digest != 0 && (digest&c.splitmask) == 0) ``` this should not invalidate...
What do you think about the following (API-compatible) change: ``` func New(rd io.Reader, pol Pol, opts ...Option) *Chunker ``` With options defined as following: ``` type Option func(*Chunker) func WithBuffer(buf...
> @SaveTheRbtz Isn't linter already enabled for flow-go/crypto [here](https://github.com/onflow/flow-go/blob/a98498f466cba094104c5b2b9206d4fd586c6af5/.github/workflows/ci.yml#L34-L43) ? also, any reason why CI does not use our local make [target](https://github.com/onflow/flow-go/blob/0f3576e2b25ea6576f2cc7652c5fbeb01ff0bf3a/Makefile#L174-L182) ? Sadly, `golangci-lint` does not recursively check sub-packages,...
Patrick has a good point. IIUC this PR has two parts: * limited concurrency * limited buffering Both of these can be accomplished by a buffered channel with a pool...
@tarakby seems like `github.com/btcsuite/btcd` is no longer developed and `./crypto/` would need to migrate to `github.com/btcsuite/btcd/btcec/v2` at some point.
bors merge