Saransh Chopra comments

Results 248 comments of


                                            Saransh Chopra

Tracking issue: migrate to `scikit-build-core`

+1 for scikit-build-core

Make private functions and classes more explicit

> We should also look into adding \_\_all\_\_ to pybamm modules Copied from the PR linked above

fix: add mypy to test dependencies

pre-commit is running in the CI (as seen in this PR, but maybe only on PRs? pre-commit.ci is faster than GH Actions so it should be preferred if there are...

Custom badge : inaccessible

Thank you for the quick reply, and the awesome API! Can this be somehow depicted on the badge itself (that the "dump" for this package is missing)? Right now the...

Custom badge : inaccessible

Thanks @AbhimanyuAryan! It works!

[Discussion]: Update and periodically test posts and model-zoo tutorials

Ah, I had not considered the limited resources available on CI. This does make it tricky. I wonder, how was `FluxBot` aiming to achieve this?

`pyproject-fmt` misplaces `[[project.authors]]` causing the build to fail

Will try to open a PR this weekend!

`scipy.spatial.transform.Rotation` Integration

H, @Elyasnz, thanks for opening an issue! This looks more like a feature request (an out of scope one). I am not sure if there are any plans to work...

Inconsistent behavior for item assignment to vector arrays

I was able to reproduce this locally. Thanks for the report! I'll look into this.

Inconsistent behavior for item assignment to vector arrays

Related to #158 - see https://github.com/scikit-hep/vector/issues/158#issuecomment-989901951 for a detailed explanation (working on this at the moment).