Saransh Chopra
Saransh Chopra
Oops, just saw the comments. I was indeed following the design guide!
I've added the missing fixity for most of the declarations, but I could not really figure out the fixity for some of them. [This gist](https://gist.github.com/Saransh-cpp/99476398a0bf6fa78f1fc6a26edbb9fc) has an updated list of...
Should be sorted now!
Hi, yes. There are a ton of conflicts and it would just be better to start this PR from scratch. Thanks for the ping!
Quick suggestions: > pytest-cov and pytest-doctest `pytest-cov` can be integrated with almost no extra config so I'll suggest including it in the same PR. For doctests, I'll suggest using [`xdoctest`](https://github.com/Erotemic/xdoctest)....
Looks like I missed a lot of discussion here 😬 But here is how you can [filter warnings in pytest](https://github.com/scikit-hep/vector/blob/6574993932ae438358cc927d02f8d30f2ff59f8c/pyproject.toml#L200-L204) - ```toml # pyproject.toml [tool.pytest.ini_options] filterwarnings = [ "error", "ignore::DeprecationWarning",...
> Should I chase for the access details? Yes, that would be great. To be on the safer side, we can enable this for `v24.1`.
> @Saransh-cpp let me know if you need the credentials to log in. That would be great, @brosaplanella. I'll be able to update everything in PyPI. > this should modify...
Ahh, I always forget about this PR. Not this time. Edit: Requested access to the PyPI project from @brosaplanella on Slack.
Okay this should be good to go now (thanks for updating the settings!) I'll delete the API key from repository secrets once this is merged.