Sander Muller

Results 42 comments of Sander Muller

Same, but with Ionic4 with Vue

> Hey thanks for your PR, > > There's already handling for files on remote disk, perhaps you can have a look over there why it doesn't work correctly; >...

@patrickbrouwers I can confirm the `app()->terminating()` is the issue, removing the delete action makes it work on our Vapor environment. I have not found a solution for this yet that...

With the help of the Serverless Laravel slack I came up with a solution to delete the file after the request on Vapor. It uses a queued closure. The PR...

@patrickbrouwers You're right, with sync as queue driver it deletes the file before serving it. A solution could be to do both: app terminate and a queued closure. Not the...

Terminating happens immediately on Vapor. So on Vapor it would immediately dispatch the job, which is fine. On non-Vapor with sync queue driver it would on terminate dispatch the job...

Perfect, I've updated the PR with the combination of app terminating and the queued closure as we discussed

> Okay that sounds pretty good then, I'm out of office until Monday, will check it when I'm back! Let me know what you think. This PR would solve quite...

@patrickbrouwers we are also still experiencing this issue on our live environment, could you have a look at it? We've been using this solution for months on a custom export,...

The difficulty with this is finding a solution that keeps the package modular so it can suit as many use cases as possible. In the case of offering addons through...