Anton Bretting
Anton Bretting
I am working on unittests, but I have ran into a problem. ``` --- FAIL: TestApply_2 (0.04s) --- FAIL: TestApply_2/apply_release_with_preapply_hook (0.00s) /home/sajfer/code/helmfile/pkg/app/app_apply_test.go:1286: unexpected log: want (-), got (+): strings.Join({ ......
The current implementation only allows one of `preapply` and `presync` to run. I have added some tests that checks that as well.
@itscaro @mumoshu Any chanse for a review? :)
@itscaro @mumoshu can you review?
@mumoshu I pushed an update that removes the prevention of double execution now.
@gakesson @mumoshu sorry for the long delay, now I have done the fixes we talked about in the beginning of summer and rebased the branch on latest main.
@mumoshu is this a bug or the expected behaviour?
That is fine for me. I can see if I can figure out how to add that.
Just to clarify, what we want is a `preapply` command that runs everytime we apply, not just when there is changes?
I created a pullrequest against `helmfile/helmfile`, https://github.com/helmfile/helmfile/pull/79