Sagar Dollin
Sagar Dollin
Things achieved in this PR: 1. I have resolved all the dependencies on RandomState. 2. The code is still backward compatible in the sense, we can load a pre-trained model...
The build-wheels checks are failing, I think this is because the file [build-wheels](https://github.com/RaRe-Technologies/gensim/commit/b3e820bcc708b95cbedab9627d03a6c34af4ea8c#diff-14b51e9e6321caf5d23b2253f2415daf475fdaa417c0aa8fe896c3a460f2d023). A change was made 13 days ago where they added `username`. The error we are getting is...
> Hey @piskvorky Thanks for your feedback. I understand your concerns. I'll give some thought to the feedback and start working on it soon.
Hi, @zygm0nt @piskvorky , Any updates on this issue? I would like to contribute to a PR if it is already created. Also, please help me with the best practices...
Hi @piskvorky @gojomo, I'm here with some updates about the work I did today. From the above comments, it is clear that we need to replace all instances of `RandomState`...
Hey @piskvorky, Thanks for your comment. Sure I will include a sanity test. I needed some clarifications for the sanity testing. 1. The Poincare model in the [gensim/models/poincare.py](https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/poincare.py), which seems...
Hi @piskvorky, The [PR](https://github.com/RaRe-Technologies/gensim/pull/3220) is ready for review. Things achieved in this PR: 1. I have resolved all the dependencies on `RandomState`. 2. The code is still backward compatible in...
> Please add unit tests for your new functionaity. Hey @mpenkov, I could test this. Would you please guide me to your expectations from the unit test. And also any...