Felix Ostmann comments

Results 17 comments of


                                            Felix Ostmann

Update parsers.py

A new coworker missspelled the label (forgot the naming part) and the parser broke the hole deck-chores container. The container fainted with a python split/parse error. ``` [...] labels: deck-chores.command:...

SUB references wrong callback, we must use outer callback

> Pretty sure that introduces a circular reference, so from me. No, this is a common workflow for working with callbacks calling itself. No circular reference.

SUB references wrong callback, we must use outer callback

> No circular reference. OK, i misunderstood your plea. There is one circular reference. Variable $fetch itself used in callback, produce one circular reference, but not for every call.

SUB references wrong callback, we must use outer callback

> Always squash your commits. I am not familiar with github, i thought this will happen on accepting MR.

SUB references wrong callback, we must use outer callback

ping? I guess i changed everything required, except the squash, how can i do this in a running MR?

SUB references wrong callback, we must use outer callback

> > ping? > > I guess i changed everything required, except the squash, how can i do this in a running MR? > > Interactive rebase and force push....

SUB references wrong callback, we must use outer callback

@jhthorsen did i get an approval now? :pray:

SUB references wrong callback, we must use outer callback

ping?

SUB references wrong callback, we must use outer callback

ping?

SUB references wrong callback, we must use outer callback

I was thinking about the new approaches for some time and they are cool, but this is a documentation and this rise the complexity in my eyes a lot. The...