SabineSIL
SabineSIL
- All tests in kmcompxtest.exe run OK (except for Vietnam, eKwTamil99UniUpdt). - removed all comments (_S2) - Replacement found for all functions in CheckFilenameConsistency.cpp - Still no replacement found for...
> That also reminds me, we need to look for all path management functions where we use `\\` and think about `/` as well. use #if defined(_WIN32) || defined(_WIN64) for...
> This is also used in the file search algorithm for NamedCodeConstants.cpp. For now, I would #ifdef this section for Windows-only and include a `//TODO: sort out how to find...
> AddCompilerVersionStore calls GetFileVersion which calls these. This could be reduced down to: - removed AddCompilerVersionStore() and GetFileVersion(); - introduced #define KEYMAN_VersionWin_W16 u"$VersionWin" in \windows\cpp\include\keymanversion_build.in since we need char16_t in...
> This can be removed -- it's testing for the user pressing Escape -- we don't want to support that in future anyway ....removed
> I think these are all related to loading a string for reporting a compiler error. I think we should move these strings from Compiler.rc into a .cpp file, and...
> LoadString > FindResource > LoadResource > If you take a look at Compiler.rc in the repository, you'll see it is filled with stringtables which are all the strings for...
Hi Marc, I committed kmcompxtest and some Tests. So kmcompx should be ready for you to review. **kmcompxtest** I added code to include Tests for checking if the correct ErrorNumber...
I finished the comments on PR 6980 except for - those we want to move to a new PR, - the one on setup of a C++ templated set of...
Here is the first draft of mcompile for Linux. Before reviewing make sure to read this [document ](https://docs.google.com/document/d/10eNrApYMC6sOj353OmjYcDqmtsI2zD2A9mxui-Y-1D0/edit) in order to - not accidentally review unfinished (deadkey related) code -...