Ryan Woods
Ryan Woods
This change has potential to break codebase's tests if they have not modified the 'country' factory 'states_required' attribute to be the intended behaviour, because the attribute can be `true`. If...
> Thanks, @RyanofWoods! > > What about a warning in the address factory? Something like: > > ```ruby > after(:build) do |address, evaluator| > carmen_country = Carmen::Country.code(adress.country.iso) > Spree::Deprecation.warn whether...
We can we wait for further opinions @waiting-for-dev 🙂
That's a good point @kennyadsl 🙂 I don't think it is for the reasons you mentioned. The following issue touches upon this: https://github.com/solidusio/solidus/issues/3842 I can look into this more 👍
> Hey, @RyanofWoods! 👋 Did you find the time to think about the proposed solution? Do you think it's something that makes sense? Hi @waiting-for-dev 👋 I added some commits...
Thank you for such a good outline of the problem @rainerdema. I looked into the problem more and wanted to add additional context. You were right about the initial total,...
> I might be a bit lost here. But isn't it effectively reverting #2913? Wouldn't #2652 still be an issue in this case? > > I haven't studied it closely...
Hey @seand7565, thanks for raising this issue. I could reproduce this error on the demo store, but could not do it locally. Even managed to get order totals above 1...
@seand7565 oh of course! 😁 Thanks so much. Looking at the database tables there are quite a few fields that have precision 10 scale 2. But many of them are...