RyanCopley

Hey sorry, I have been on vacation without access to slack. One important thing to also validate is running Argo lint on those exact same use cases. If you do...

After talking with @caelan-io, i think it would be very beneficial if someone could help me understand this system a bit better: https://github.com/RyanCopley/argo-workflows/blob/254b85db4b4d77f2530bfed24b29e94b3b25cfb8/workflow/validate/validate.go#L872-L879 What exactly is this condition for? Could...

With this specific case outlined (hopefully it's clear!), i honestly don't know how this `argo lint` system is supposed to work here. Can someone explain if it should execute ```go...

Currently this is what I've been trying: https://gist.github.com/RyanCopley/11231560 (And I've added annotationIdentifier to the RMAnnotation class), I'm working with the Cocoapods version so I don't think I can commit and...

https://github.com/RyanCopley/mapbox-ios-sdk/commit/23f6087da0b487328a218b52ffb43cadba2d473c This seems to work, could you take a look and see if there is anything obviously wrong with it? To setup, setup multiple different annotations and give them different...

The someArray in ``` RMQuadTree -addAnnotationsInBoundingBox:(RMProjectedRect)aBoundingBox toMutableArray:(NSMutableArray *)someArray createClusterAnnotations:(BOOL)createClusterAnnotations withProjectedClusterSize:(RMProjectedSize)clusterSize andProjectedClusterMarkerSize:(RMProjectedSize)clusterMarkerSize findGravityCenter:(BOOL)findGravityCenter ``` confuses me-- What is this someArray for?

I found an issue in my implementation, this one works better: https://github.com/RyanCopley/mapbox-ios-sdk/commit/dbdef8ec57f2a1f246bb70ad2f2588e203d99c8f I was accidentally re-filtering the results over and over again. This is obviously not right :) I'll roll...

I analyzed this a bit more and I determined some major flaws in my current implementation, I think I have the right idea of how to fix this :+1:

https://github.com/RyanCopley/mapbox-ios-sdk/commit/7d9ab7c8c8fe1bfa8fb48b263b051f980a28ff1a This seems to work great. The commit might need cleaned up however. If we can agree this is a good solution, I can re-write it to be a bit...

There is a need for some @synchronized blocks around some of the code I didn't address... Some race conditions were identified :(