Ryan Liao
Ryan Liao
**Is your feature request related to a problem? Please describe.** Okapi offers an excellent framework for teams to build their code upon. However, the velocity controller builder only supports building...
## Summary Rename max_file_num_to_ignore for compaction parameters to min_file_num_to_ignore. For reasoning see #13692 ## Verification ### Unit Test ``` Running testBlobBatchPut... .Running testBlobDump .Running testBlobPut... .Running testBlobStartingLevel... .Running testCheckConsistency... .Running...
Within a lot of compaction code, there is a parameter ```max_file_num_to_ignore```. For example this is the declaration of ```CompactionPicker::CompactRange```: ```cpp virtual Compaction* CompactRange( const std::string& cf_name, const MutableCFOptions& mutable_cf_options, const...
## Summary 1. RunManualCompaction notifies the user what level is currently being compacted 2. RunManualCompaction and CompactRange logs the result of a compaction (scheduled, cancelled, skipped, can't be scheduled etc.)...
Currently during manual compaction the logs are not very informative about what happens for each compaction (i.e. what levels are being compacted, whether the compaction succeeded) ## To reproduce Create...
1. LogAndNotifyTableFileDeletion doesn't check if event_logger is a nullptr, and would crash if so 2. LogAndNotifyBlobFileCreationFinished and LogAndNotifyTablebFileCreationFinished only log locally, when the status is ok, but event listeners are...
BuildSubcompactionJobInfo doesn't store compaction_reason, compression, and blob_compression_type. Since this function is used to build info that is then passed to listeners, listeners have missing information about the state.
I checked out master (up to 20d065d940dcc39d4f5dbbdc90085fb50bbc9ebd) and tried running ```make check -j 32``` and got the following error: ``` Computer:jobs running/jobs completed/%of started jobs/Average seconds to complete ETA: 4814s...
Why reinvent the wheel. See [here](https://github.com/aurora-opensource/au)