Rusty Bower comments

Results 53 comments of


                                            Rusty Bower

reload: Reloading packaged modules doesn't work correctly

I just tested against #1314 and it is definitely causing all my modules to respond n+1 times

value.nick_values column isn't long enough

This should be handled via #2317

db: make value.*_values TEXT instead of String(255)

I'll test the migration this evening. Otherwise we can make some "prerun" script that runs that validates the state of the database.

db: make value.*_values TEXT instead of String(255)

Also IIRC, the reason everything is set for String(255) was either compatibility with the old database or because of SQLite weirdness with SQLAlchemy...

db: make value.*_values TEXT instead of String(255)

So testing this, it appears there's no weirdness with MariaDB or SQLite in terms of the schema. @dgw I'm happy to follow this up with some [Alembic](https://alembic.sqlalchemy.org/) work, since that...

db: make value.*_values TEXT instead of String(255)

Digging into this further. This is super breaking, because SQLite doesn't support the alter column functionality that other SQL engines support (https://www.sqlite.org/omitted.html) Although it appears you can hack around it...

db: make value.*_values TEXT instead of String(255)

I think you're correct. Although trying to implement this dynamically to leverage db.get_uri() function from the bot is not as straightforward as I would have hoped. You can leverage some...

db: make value.*_values TEXT instead of String(255)

This should be handled via #2317

Feature: Abbreviated humanized time output

I've pretty successfully used https://arrow.readthedocs.io/en/latest/#humanize to create "humanized" output from a datetime object

implement alembic to handle database migrations

I do need to figure out how to automatically run Alembic for new versions of Sopel 🤔