Rui Pedro
Rui Pedro
Hey @nodexchange, Thanks for the help here :) A few questions : 1. By adding the build in .gitignore how did you ensure the system automatically build when people use...
Great, yes please do 1) so that we keep the build outside of the repo itself and just autobuilds in github actions Also please resolve the conflicts, once done let...
@nodexchange does this substitute the previous pre-commit solution of [lint:fix, build, jsdoc:build]?
Great @nodexchange can you pls resolve the conflicts so that I can merge? Thanks!
Thanks @nodexchange, now only **left is the build/ files, since now we ignore all build files - so just need to remove any build/** ** - the rest looks ok...
@nodexchange let me know once that is done so that I can merge, all the rest looks great!
@tbem can we just assume 1 fee based address as that all transactions (included the first one) have the fee sent to the address Y? Otherwise it would consume a...
- [x] createPacks -> createPack - [x] editPackLimit -> editPackInfo - [x] deletePacks -> deletePackById - [x] deletePackById - [x] getPacks (This call should be taken offchain with the filtering...
**Events to Be used below** `event PackCreated(uint256 packId, uint256 nftsAmount, string indexed serie, string indexed packType, string indexed drop);` `event PackOpened(address indexed by, uint256 indexed packId);` `event PackDelete(uint256 indexed packId);`
- packIncrementId starts at 1 - removed packNumber and added opener variable in Pack Object (stack to deep problem in ethereum - not enough space for duplicated variables) - added...