Rudra Saraswat

Results 14 comments of Rudra Saraswat

@noah1510 This is because /dev/binder is no longer created. You can safely ignore this, AFAIK. Seems to be a bug.

> Please run another trunk.sh I got this when running trunk.sh again: (should I checkout any particular branch before running trunk.sh again?) ``` Rebasing/Syncing and running hooks... Previous HEAD position...

> @RudraSwat It was a rebase error on my part > See fix > https://github.com/Alex313031/Thorium/commit/bc0c0040da5c32ad160975ca56083408ed10cb72 Ah, I'll try that. Thanks :)

@Alex313031 This new added file doesn't seem to exist either: `content/browser/preloading/prerender/prerender_page_holder.cc` in the Chromium source code.

@Alex313031 Just did that and ran build.sh and got these errors: ``` ../../chrome/browser/chrome_content_browser_client.cc:3819:16: error: no member named 'text_track_window_padding' in 'blink::web_pref::WebPreferences'; did you mean 'text_track_window_radius'? web_prefs->text_track_window_padding = style->window_padding; ^~~~~~~~~~~~~~~~~~~~~~~~~ text_track_window_radius ../../third_party/blink/public/common/web_preferences/web_preferences.h:199:15:...

@Alex313031 Tried doing that and got a new set of errors (related to the changes in the past few commits): ``` In file included from ../../chrome/browser/about_flags.cc:3281: ../../chrome/browser/thorium_flag_entries.h:17:43: error: expected '}'...

@Alex313031 That seems to have fixed those issues. Get these new errors now: ``` ../../chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc:1951:6: error: use of undeclared identifier 'IDS_SETTINGS_SAFETY_CHECK_UNUSED_SITE_PERMISSIONS_PRIMARY_LABEL' IDS_SETTINGS_SAFETY_CHECK_UNUSED_SITE_PERMISSIONS_PRIMARY_LABEL}, ^ ../../chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc:1972:16: error: no matching member function for...

@gz83 That seems to have fixed most of the issues, and looks like the build was almost successful after making those changes. I get this linking error now: ``` ninja:...

@Alex313031 That seems to have introduced another error: ``` ../../third_party/blink/common/features.cc:1562:32: error: unused variable 'kPretokenizeInlineSheets' [-Werror,-Wunused-const-variable] const base::FeatureParam kPretokenizeInlineSheets = { ^ 1 error generated. [1 processes, 2266/5249 @ 52.4/s |...

@gz83 These changes seem to already be present in features.cc after https://github.com/Alex313031/Thorium/commit/687d83972bbb3777c486222dee2e54fcbfc2645e.