roy

Results 8 comments of roy

> Hi @RoyWFHuang There is something wrong on my environment to use kmemleak, I will check later. @HotMercury `error: attempt to use poisoned "strlcpy"` Is that the problem you encounter?...

You can test the example in kmodleak, you will see that 1 stacks with outstanding allocations: 128 bytes in 1 allocations from stack addr = 0xffff8c4204ae7300 size = 128 0...

> > Make the git commit messages informative. In particular, mention the way how you figure out the potential leaks. > > @RoyWFHuang, can you improve the git commit messages?...

> How can you determine which hash function is the most suitable? I’m not sure if "fnv" is the most suitable, but index in SimpleFS is relatively small, using a...

> I saw that your PR description includes some performance benchmarks, but the commit message lacks any performance numbers to support your improvements. Please improve the commit message. Added all...

> Quoted from patch 2: > > > Align the print function with the Simplefs print format for consistency. > > Also adjust variable declarations to fix compiler warnings when...

> Hmmm, I see my comments were marked as resolved, but I don't see any changes or replies. Since you re-requested a review, did you perhaps forget to push the...

> I checked my email and didn't see any replies between the two review requests. I also checked the gihub web page and expanded the 'show resolved' threads on my...