Roy Stegeman
Roy Stegeman
Why is this a cli command and not just a vp action?
This was not done in this PR, but I changed it since I don't think we should start getting in the habit of suppressing warnings if there is another option
No, removing "r" is just because that's the default option anyway. The warnings are fixed around line 900 in [legacy_jets_utils.py](https://github.com/NNPDF/nnpdf/pull/2056/commits/de3924c1ef28ca10d8f0d2d168b26440b7e62e23#diff-b496557b2e9ae2d03feedfd642d255be857cebdf9a9f12b76794574609322a54). A similar error, with similar solution, that I didn't fix...
Since filter files will now share utilities, and we may need to change/fix those shared utilities at some point - do you think it's feasible to run all filters in...
https://github.com/NNPDF/nnpdf/blob/eed00c75b4910606e967d1d0be644a45fd44b913/validphys2/src/validphys/process_options.py#L27 @scarlehoff what should be done in this PR?
@comane I see you addressed the CI fails (as pointed out by @Radonirinaunimi), but could you rename p_T2 to pT2?
I assume @scarlehoff wrote it. Either way I agree with it for consistency with pT and pT_t
Should this be on top of `new_commodnata_utils` or `master`? Currently it contains commits that are in `master` but not in `new_commodnata_utils`.
I wasn't there so I don't know what was discussed, but rebasing on master indeed seems reasonable to me
Is there a report (ideally comparefits) that includes this dataset?