Rondineli
Rondineli
@aahung fixed, thanks for the review!!
@moelasmar thanks for replying. That makes sense and it is a valid concern. My thoughts were get a way of not change the actual behaviour as it can break existent...
> @Rondineli I have some concerns about this change breaking existing customers even behind a feature flag. Please have a look at the comments on the original issue. Sorry, but...
Yes, it does, but in my case I would need to change only partial the rules. Not the entire Property unfortunately. Part of the objects are made from cdk, and...
As part of my rules are cdk objects, I cant use it to replace the whole property, according to this: ``` The `value` argument to `addOverride` will not be processed...
Tehe deletion is happening on this block: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/core/lib/cfn-resource.ts#L728 I added some logs locally and can see This deletion happening: ``` if (typeof(output) === 'object' && Object.keys(output).length === 0) { console.log(`Target...
I tried the escape hatch by trying to override only the Action key as well, and it did not work, anything that maybe mix the cdk construct and cfn plain...
> @Rondineli Based off of @pahud's workaround of using `addPropertyOverride` on `Rules`, if you just changed the first parameter to `Rules.1` it seems to work, and that way it shouldn't...
@paulhcsun sorry the late reply here, but, as I said, when trying what you suggested, I get this on cloudformation: ```bash .... "Model validation failed (#/Rules: expected type: JSONArray, found:...
@vinayak-kukreja I got it! That makes sense, as the Keys can be used in others resources and being removed. I can re-work my PR to fit your suggestions or if...