Roman971
Roman971
FYI I made a PR with some fixes to format.py in oot (see zeldaret/oot#1387), and it will probably prevent that coring issue you ran into
Looks good to me overall, I simply commented on a couple existing comments
I don't have a clear opinion on this topic yet but I'll try to give my current thoughts. Basically right now I feel like we shouldn't bother at all with...
I'm not opposed to this idea and I have considered it myself many times in the past, but I still don't know if it would be an improvement overall considering...
What's stopping us from renaming `GetItemID` and `GetItemDrawID` enum values along with those? Imo we should definitely keep these enums in sync and it would make a lot more sense...
> Could you demonstrate how UNUSED for arguments makes changes difficult? Having UNUSED in arguments mostly just adds more stuff to keep track of, especially since a distinction is made...
> I didn't think of the case of a temp that would be used in only some versions, making it stack padding in others. I have no idea if that...
Wait really? GCC doesn't error or even warn if a variable declared unused is actually used? That makes it so much worse than it already was in mind lol
Thank you for your report and all the details, it does look like there is a general issue with generating multiworld seeds with a lot of shuffle settings. I was...
Just to be clear, pickup speedups are not in this fork yet, and thus this issue won't be reproducible in the current Dev version.