Jack O'Brien comments

Results 25 comments of


                                            Jack O'Brien

Plasma/kilonova zeta

Please fix merge conflicts!

STELLA to TARDIS bridge

So how "complete" do we want this bridge to be? Right now, a tardis compatible csvy file can be generated from stella in only a couple lines of code entirely...

STELLA to TARDIS bridge

Nest Step: Autogenerate the yml portion

Moved csvy parser to model_reader

Please fix the current merge conflicts

Tardis cannot parse elements which are not formatted starting with capitalized characters

> Upon further inspection, the way TARDIS parses isotope names requires that the names be capitalized like they are by convention (i.e. Ni as opposed to ni). This could be...

Tardis cannot parse elements which are not formatted starting with capitalized characters

This issue is important because it breaks backwards compatibility currently with older abundance files

TARDIS May produce different results when multithreading.

Should be noted while this was partially fixed by #2022 there may still be inconsistencies in the v_packet energy histograms as they are not properly handled in parallel (though the...

Add array_diff tests to functions

This PR requires updates to the tardis-refdata and azure testing pipelines to properly use pytest-arraydiff

Consider config option for numba recompile of montecarlo_main_loop

#1901 Now no longer include the recompile and we're not sure about possible consequences! Once merged, this should be a priority issue, if not one now

Move CSVY writer from custom abundance widget to io

Either in the same folder with the reader, or a new sub-module with writers. Be aware, the csvy writer needs to be rewritten a little to make sure it is...