Roxana Burduja
Roxana Burduja
After a discussion with @razvancir96 we agreed that our team will take over this PR from next week. @Westbrook are there any concerns about this functionality besides the code review...
Given that the progress spinner is spinning inside the picker, VRT will fail because of different states of the spinner. Was there anything similar being done in the repo so...
I have no more things to add to this PR. Happy to implement any other feedback if there is. cc: @Westbrook @TarunAdobe
`getElementById` works too (even with whitespaces, which is another edge). Another thing I noticed here is that when I select an option using the keyboard, the `change` event is not...
I'm marking it as ready for review even if unit tests are incomplete, because I am looking for a high level review of this current implementation, and any changes would...
@Rajdeepc as per office hours discussion, I removed the `trigger` directive usage and went back to `sp-overlay`, as it was better suited for my component.
> Can you look into why these examples don't work for this component? @TarunAdobe seems to be due to the type of the controls: `radio`, `number`, and `text` which do...
@blunteshwar I observe this, however, the failing tests are not related to this PR, and the error seems to be for Action Button `Error: There was no baseline image to...
Is it possible the build process runs different on the CI and I am overlooking something, @Westbrook? I don't want to say "it works on my machine" but this build...
@Westbrook Fair point, I'll discuss within the team the possibility to test this as a pre-release in Express.