RobertoHE

Results 30 comments of RobertoHE

That's true. Example code must use `BLEMIDI_NAMESPACE::` `DefaultSettingsClient` as default struct. If you change this, the example compiles with errors?

Client example code modified.

Is It possible to merge the pull request? If not, say me what changes it needs. I think that struct settings are better than modifying defines directly in lib. I...

> Correct, it might be better the use the settings! I made changes to the BLEMIDI_ArduinoBLE.h that I have just uploaded - can you check if this works on your...

@lathoub Please, check the autotest Logs of the project. CustomSettings.ino compiles successfully, but some errors appear in the other examples. Please, use this branch (or my fork repository) to fix...

Check this post: https://github.com/arduino/arduino-cli/issues/765 @lathoub

DONE. @lathoub consider extending Struct settings to other transport layers.

> Do you want to define LED-BUILTIN in the examples? (I believe this macro is defined in the device definition) I am using PlatformIO within VisualStudio Code and this macro...

Yes, with build_flag you can set any #define in compiling step if compiler doesn't have this #define. The problem (for a beginer with no knowledge about programming who only wants...

> Thanks for the thourough investigation @MicroMidi and response @h2zero. > > I would suggest to add a parameter to the client connect > > ``` > bool BLEMIDI_Client_ESP32::connect(bool response...