Robert_Ordis

Results 12 comments of Robert_Ordis

sorry i forgot to commit "changed" test code. I'll push them later. ->pushed

Thank you for replying. Because of prefering to implement earlier, there are various dirty code probably. So, please show me the better approach if you find.(especially, Config.TimeSeek, Config.width...)

Can I submit more pull requests ? I tried to add more abilities for my own purpose. - Showing reticle and actual value from specified position(x, y) - Handling mouse...

Yes, I know. I'm wondering if my pull request will be accepted or rejected, ... or just ignored or forgotten. (I knew Mr.Callarec's newer commiting recently.) Rebasing is my job...

@stsdc Thank you for your comment. Did you see my code? 2nd of my additional features(Mainly, about the reticle) are not in "master" branch in my repository.

@taozuhong Thx. I'll find my time to do it. I also tried to performe my code on GTK4(may be working). (I really hate the breaking change of API of 3...

Good morning @lcallarec . I'm glad to receive your reply. (sorry for my bad English if this is hard to read) Because of my too much piled up modification, reviewing/merging...

Thanks for revieweing my noob-like PR... Then, I'd like to make my modifications tidy up once. (Including the features not pushed here yet) In this case, what should I do...

Started first (#38). @taozuhong How do I treat my mods for Gtk4 ?(maybe conflicting between mine and yours)

Started 2nd (https://github.com/lcallarec/live-chart/pull/39).