Rishhi Balakrishnan
Rishhi Balakrishnan
Is webpack capitalized?
Not going in this direction anymore
This is handled by this PR; https://github.com/microsoft/FluidFramework/pull/20976
@jatgarg @sonalideshpandemsft the next round after this stage we are rolling out the code changes to remove the es lint disables
I will go back to all the TODO comments and update them with the standardized comment
> > } > > Looks like a breaking change to IDocumentDeltaConnectionEvents disconnect event > > Refers to: packages/drivers/driver-base/src/documentDeltaConnection.ts:451 in [dbdc5b1](https://github.com/microsoft/FluidFramework/commit/dbdc5b1aa8411d31137c4c1582fc73c563cb53cf). [](commit_id = [dbdc5b1](https://github.com/microsoft/FluidFramework/commit/dbdc5b1aa8411d31137c4c1582fc73c563cb53cf), deletion_comment = False) Ah thank you!...
> @RishhiB Did someone ask for this change? One is that it is a breaking change and I don't think we can merge it like this as it might break...
moving to 2.60
Closing since we are not going forward with making the disconnect event optional