Daniel Richter

Upgrade to Symfony 5

13

This includes auto-wiring, annotation-routing..

Treat Tab key same as Enter for select purposes

8

First off - thank you so much for this project, it works like a charm and saved me a bunch of time. I have one suggestion: I'm using this auto-complete...

This seems like a micro-optimization, but we are running this code in a tight loop and this saves 5 unnecessary allocations.

We have a use-case to customize the expiration time for the vapid token. This adds this functionality in a backwards compatible fashion.

Gaufrette FTP defaults to FTP_BINARY, but Bundle defaults to FTP_ASCII

2

There is an inconsistency in the default values between the library and bundle: Bundle - FTP_ASCII https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/DependencyInjection/Factory/FtpAdapterFactory.php#L52 Library - FTP_BINARY https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Adapter/Ftp.php#L48 Not sure that the bundle needs to specify a...

Defaulting to ENV vars during container build is problematic

1

First off, this bundle has come a long way and I really like it now, great job, and thank you! One snag I ran into though: ### Expected behavior According...

In v4 the following expression/var combo yields `15`, in v6 it evaluates to `105` ``` a + b ``` vars: ``` map[string]interface{}{ "a": "10", "b": 5, } ```

The following expression has changed results between `v6.0.0` and current `master` branch: ``` {{ _missing == null }} ``` Given no parameters. v6.0.0 output: `True` master output: `False` In understand...

Optimize context valid identifier check

1

This might seem like a micro-optimization, but we are using this library in a tight loop with a large input map, and the regex usage is adding up. This PR...