Richard Cai comments

Results 11 comments of


                                            Richard Cai

Panic when running UNION on SHOW BACKUP queries as non-root user

> But what if the uri is to a userfile location? Until we parse the host we don't even know what table name to resolve let along priv check We...

sql: add user_id column to system.role_options table

This PR borrows a lot from https://github.com/cockroachdb/cockroach/pull/81457 - the PR to add the user_id column to system.users but should be slightly more straightforward since we no longer have to generate...

sql: add user_id column to system.role_options table

> This seems fine. > > > Reviewed 4 of 4 files at r1, 30 of 57 files at r2, 1 of 2 files at r3, all commit messages. >...

sql: add user_id column to system.role_options table

Thanks for reviewing! bors r=ajwerner

sql: add user_id column to system.role_options table

Trying again bors r=ajwerner

sql: add user_id column to system.role_options table

bors r=ajwerner

Role members table migration

Bump @ajwerner @rafiss, thoughts on merging this? Given that it's the same as the `system.users and system.role_options` ones, I figure it's fine. Also it's somewhat strange to have the other...

Role members table migration

> Given nothing uses this, do we get benefit from having migrated all the tables? Is it correct that nothing uses it? > > > Reviewed 6 of 24 files...

Allow users to pass certs when PG environment variable PGSSLMODE=require/verify-ca/verify-full

> They shouldn’t be required, just supported. Gotcha, thought erroring would be better since if certs aren't passed in with the SSLMODEs then they won't be able to connect and...

Allow users to pass certs when PG environment variable PGSSLMODE=require/verify-ca/verify-full

Updated so that it'll return an object with the cert properties. Please let me know if this is reasonable, mostly the part about returning undefined if the environment variable is...