Michael Render

Results 65 comments of Michael Render

Note on the existing functionality: ``` csharp System.Text.Json.Nodes.JsonValue? stjTrue = System.Text.Json.Nodes.JsonValue.Create(true); string serialized = Newtonsoft.Json.JsonConvert.SerializeObject(stjTrue); // Newtonsoft.Json.JsonSerializationException : Self referencing loop detected for property 'Root' with type 'System.Text.Json.Nodes.JsonValueNotTrimmable`1[System.Boolean]'. Path ''....

Just noting that [`OpenQA.Selenium.DevTools.DevToolsCommandData`](https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/DevTools/DevToolsCommandData.cs#L36) has a public constructor which takes `JToken`, in fact only `JToken`. This gets used by the [`SendCommand`](https://github.com/SeleniumHQ/selenium/blob/da62a402d0565dd2dda2ced71cf74965caa4391c/dotnet/src/webdriver/DevTools/DevToolsSession.cs#L242) method, Which takes a `JToken` directly (this is the...

I see. Looking at the documentation for `exposeBinding`, it looks like its designed to inject HTML into the DOM, and wouldn't work for the `mousemove` scenario I laid out. Is...

I fidgeted with the settings and couldn't find one to turn this off, so for now I turned off format-on-save for comments completely.

> - NUnit & XUnit not compatible with NativeAOT. > - MSTest only supporting a subset of functionality in NativeAOT mode. > - The native build time is long enough...

Making the library trim-compatible is good future-proofing hygiene, and ensures consumers know which methods aren't trim- or AOT-safe. Would the maintainers accept PRs annotating the Playwright libraries for trimming and...

`[OneTimeTearDown]` runs after the entire line of `[TearDown]`'s finish, so I don't think this is possible. I would add `[Order]` to all the tests, and give your cleanup method `[Order(int.MaxValue)]`

My current workaround is this (C#) ``` csharp public async Task GetClipboardAsync() { IPage page = await Context.Context.NewPageAsync(); await Context.CurrentPage.SetContentAsync(""); ILocator target = page.Locator("xpath=//textarea[@id='target']"); await target.FocusAsync(); string controlKey = page.Context.Browser!.BrowserType.Name...

You can do ``` csharp static bool DefinedInCorelib(Type type) { return type.Assembly == typeof(object).Assembly; } ```

The corresponding exception here is `ArgumentNullException`. `NullReferenceException`s should never be thrown by user code and is always considered a bug