Red Kalab

Results 12 comments of Red Kalab

> Are there ways in which the proto3 JSON mapping differs from what serde can do? Found one, protobuf `bytes` type maps to a base64 encoded string. I copied a...

I was following the steps shown in the fastapi section https://github.com/prometheus/client_python/#fastapi--gunicorn which uses `make_asgi_app`

Looking at your code snippet, why sqlx operations are async, and the `handle` function should also be async, not sure what the goal of adding `block_on` and async again is....

Would it make sense to make a `send_local()` function that takes `Message` and would error out if its a `RemoteActorRef`? Then you could require `RemoteMessage` on `send()`. This would only...

Actually, I realized this is not actually great, since the handle method needs to be implemented as well, which kind of breaks it. Not sure how about fixing that

I am not quite sure why the CI failing, I dont see any failure in the logs

Hi, thanks for the review! In regards to the defaults-related PR, `#[pyclass(auto_new = "from_fields")]` and `#[pyclass(auto_new = "default")]` make sense to me, names sounds fine. As for the followups, I...

@davidhewitt in regards to `generate_protocol_slot` for `auto_new` should that be a new `pub const __NEW__: SlotDef`? not sure what else but just confirming @Icxolu i think it might be a...

I am running into an issue, I think `generate_protocol_slot` assumes first argument is `self`, and generates broken code when it isn't. Image below shows `cargo expand`ed version of this simple...

looks like `nox -s update-ui-tests` isnt working for me :/ I think I am running on a different rust version producing slightly different errors, as it slightly modifies unrelated tests...