Rikard Blixt

Results 146 comments of Rikard Blixt

`need-check-nil` when nil check is done in a function

If the isEmpty annotations are changed from ```lua ---@param str string? ---@return boolean local function isEmpty(str) return str == nil or str == '' end ``` to ```lua ---@param str...

feat(standard): add Boosty to Links Module

@Erghel how's it going?

feat(standard): add Boosty to Links Module

Closing as stale, feel free to reopen is that changes

feat(Transfer): Add Transfer components

Brawl Halla requesting shortnames display

feat(Transfer): Add Transfer components

> modules sync discussion: > > * always show short names > > * shortname can be a mess (pretty long) on some wikis > * some wikis certainly wouldn't...

feat(Transfer): Add Transfer components

Could you add some tests? At least some smoke/golden test?

feat(Transfer): Add Transfer components

Make sure to add the transfer_list folder to test_helper.lua

fix(opponent) Add AoE custom opponent with special name resolving

I need to think if this has another impacts that could be negative

fix(opponent) Add AoE custom opponent with special name resolving

Could you list exactly which functionality breaks without this? I see TC -> Match link in OP but what else?

fix(opponent) Add AoE custom opponent with special name resolving

Match/Legacy for GTL as stopgap seems fine Is the problem that the M2 looks for `Team Liquid` while TC stores `Team Liquid A`, or the other way around?