Ramon Zhou
Ramon Zhou
> How much slower is this new implementation compared to the old one? @mfbalin The time complexity should be the same. I also tested on my local machine, there's no...
> > > How much slower is this new implementation compared to the old one? > > > > > > @mfbalin The time complexity should be the same. I...
@mfbalin I tested again with the latest master branch merged. It's 7.911s (before) vs. 7.919s (after)
I did another test and the results are (features are sliced with `[:, :32]`): - Old version: 5.817s - Current PR (with the `if` inside the loop): 5.802s - Current...
> > I did another test and the results are (features are sliced with `[:, :32]`): > > > > * Old version: 5.817s > > * Current PR (with...
> > > > I did another test and the results are (features are sliced with `[:, :32]`): > > > > > > > > * Old version: 5.817s...
> > > > > > I did another test and the results are (features are sliced with `[:, :32]`): > > > > > > > > > >...
Let's merge this first and optimize in the future.