rafe
rafe
I've also experienced frustrations with servers timing out WS connections after not receiving a message within a certain time. Adding a scheduled heartbeat only goes so far, since the browser...
i'm not sure if there's an easy way to test this fix. if there is, please let me know and i'll have a go
this looks like a more broad limitation of the datetime matchers. currently, any datetime supplied needs to be in a format that can be parsed to a full `LocalDateTime` or...
> Hello @RafeArnold, thank you for your response. > > You are correct to point out that my proposal doesn't take under account `yyyy-MM` for which `YearMonth` would be needed....
looks good. can support be added for custom formats too, like we already do for localdatetime and localdate?
can you add tests to EqualToDateTimePatternTest.java for the custom formats, to assert the new parseYear and parseYearMonth methods are being used by the pattern matcher?
Is there anything to be done to push this PR and https://github.com/ajalt/clikt/pull/621 through? If it's just a matter of finding the time to review then I understand.
> Sorry for the delay. Since the changes are backwards incompatible, I've been waiting until I have time to make a major version release. Totally understandable. Just a heads up...
i think the ability to construct the location string lazily would be useful, as it's only used for the unhappy path of parsing and could potentially require more complex computation...
@dependabot rebase