Jonas Peschla

Results 80 comments of Jonas Peschla

Of course we can handle addressable's execption and wrap it internally in json-schema to get along. But as using exceptions for control flow is considered bad in general in programming...

Yes, I used `rake spec` but I should have used `appraisal rake spec`. Considering my comment in the code above, maybe it would be a good idea to have different...

@ochealaaf I would really appreciate a short Howto on where to put the values. My first guess would be to add these variables to `roles/docker_container/files/php.ini` but well I am not...

Thanks @ochealaaf that worked like a charm. :smiley:

@ochealaaf Do you also found a way to persist that change so that one does not have to redo the change after every time the container is rebuilt like after...

@ReinerNippes I pulled `master` after your last message and rerun the Ansible script/recipe with unchanged settings over the existing installation (I hope/think that is how updating the config works?). Today...

No, this is not intended behavior, it actually is not considered behavior. First, the `$schema` keyword is recommended but not required. Second, json-schema currently uses draft4 as default if no...

Ok, I guess, then we should simply add that schema key as a default if none is given as json-schema states that it uses draft-4 as default anyways. Or do...

Well, laziness ... :smirk: You are right, of course and I think this should actually be as easy as adding the key on initialization. I'll prepare a fix some time...

@gregoryjscott I cannot reproduce this. When I run your example with json-schema 2.6.0 and Ruby 2.2.3 and also 2.2.4 the custom format validation is detected as intended. The [tests](https://github.com/ruby-json-schema/json-schema/blob/master/test/test_custom_format.rb) (should)...