Matt Hauff
Matt Hauff
This PR is technically good to go in terms of this repository, the problem is that since the types will be detectable now, the `chia-blockchain` repository is going to face...
I agree @mariano54 it just would have required a rather large PR into chia-blockchain (and certainly a larger one now). One of the biggest fixes will be that `SerializedProgram` and...
The behavior of this PR now is to try every coin state in a DB transaction and try/except block. If it fails for whatever reason, the DB is rolled back...
> Should we also raise PeerRequestException on the other types of failures? > For example, request_header_blocks, request_additions, etc etc This PR is focused on improving the flakiness of coin states,...
You're going to need to add test coverage of the `if eve_spend` branch in order to get CI to pass: ``` chia/cmds/wallet_funcs.py (11.1%): Missing lines 724,727-732,734 ```
> @Quexington Can you point me to where this whole NFT royalty branch is covered? I can't see the coverage report from the CI. > > I've found `tests/cmds/wallet/test_wallet.py`, but...
This is in draft because it probably should not go in while there is an outstanding release branch.
The consensus folder has (to me at least) an important connotation of "touch this only if you have to". Is there a reason we're taking it out of there? Is...
Util doesn't strike me as the proper place for this, it has to do with a specific full node optimization, I'm not sure what other part of our project might...
Yeah as Arvid said (and I've discussed with Amine offline), this function is very helpful when developing new chialisp and you run it _alot_ so even requiring a separate import...