Marcin Kowalczyk

Results 10 comments of Marcin Kowalczyk

Here is some related code: https://github.com/dart-lang/sdk/blob/46bc947e75ca3ad2004e835e2b2698b61aab102f/runtime/bin/file_win.cc#L468-L469 https://github.com/openjdk/jdk/blob/e80b5ea448c715519d14e238321ceb5ec40b37f4/src/hotspot/os/windows/os_windows.cpp#L4440 I have never programmed for Windows though.

Update: It is sometimes possible for seeks near the current position to be performed within the buffer, and not to cause flushing of the buffer. I made such change in...

I do not expect libzip to seek within the buffer, since buffering is applied by the implementation of the source, i.e. in general by the client of libzip. For `zip_source_file_create()`...

One way to solve this without changing `zip_stat_t` would be to allow switching between using the local timezone/DST and UTC. This would affect translation between `time_t` and DOS timestamps the...

Let’s say an archive was written in Europe with entries modified at 12.03.2023, 2:30:00. Then the archive is opened in the US, some entries are modified, and the archive is...

When libzip opens the file, it translates timestamps from the DOS format to `struct tm`, then uses `mktime()` to translate that to `time_t`. When libzip writes the file back, it...

Ah, my example was misleading. It was `mktime()` which adjusted its input as a side effect. So confusing API! Still `localtime_r()` writes the same `struct tm` as was adjusted by...

Thank you! I think this is workable, but it would be nicer if the DOS time was returned by `ZIP_SOURCE_STAT` rather than a separate `ZIP_SOURCE_GET_DOS_TIME`. My wrapper for `zip_stat_index()` fills...

It helps in the sense that the request syntax is no longer rejected, but a resumable upload still fails. The same test succeeds against the real GCS server. I don’t...

Here is a strace log of socket communication (of a similar but different run — this is a randomized test): ``` sendto(12, "POST /storage/v1/b?project= HTTP/1.1\r\nHost: localhost:27454\r\nUser-Agent: gcloud-cpp/v2.11.0-rc.g3+piper (Clang-9999.0.0; noex) libcurl/8.0.1-DEV...