LI Qingwu

Results 10 comments of LI Qingwu

> let me know what do you think @Qingwu-Li I will have a look on it!

from your log see“Entering dimmed state...” , in dim mode ,the backlight adjustment not working.

1 'wpe_view_resize' was not declared ``` Source/WebKit/UIProcess/API/wpe/qt6/WPEQtView.cpp:87:5: error: 'wpe_view_resize' was not declared in this scope; did you mean 'wpe_view_resized'? 87 | wpe_view_resize(wpeView, d->m_size.width(), d->m_size.height()); | ^~~~~~~~~~~~~~~ | wpe_view_resized ``` 2...

> Thanks for your contribution Li! This needs a small change, then it can go in. Unfortunately we're not testing the Qt6 compilation upstream at present, therefore future breakages will...

Can anyone review the change?

> Looks good, two style comments left. I will r+ the patch nonetheless. Just update the patch and I will set mq+ later. > > I assume you tested it...

> * Is Qt6 WPE not yet supported in `2.44`? If that is the case, we could consider adding support for `2.45` as an exception, but with `DEFAULT_PREFERENCE = "-1"`...

modifed Upstream-Status to `Upstream-Status: Submitted`