Gustas Kažukauskas

Results 605 comments of Gustas Kažukauskas

I'm just wondering, where do we want the delay? Before `Drag` activity or after, and do we want to consider the harvester as still docked or undocked while waiting? If...

It might be worth scope creeping this into adding a configurable before unloading delay. Currently it's hardcoded to 10 ticks https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Activities/DeliverResources.cs#L74

Ah, in that case the delay should be after fully finishing the `HarvesterDockSequence` activity. Call ```c# QueueChild(new Wait(Harv.Info.UnloadFinishedDelay)); ``` In https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Activities/HarvesterDockSequence.cs#L94 just before `return true;` Perhaps could also add a...

This will need an update rule Also, with the docking refactor I plan to replace `DeliveryBuildings` with bitset dock types (identical to `CaptureType`) , so any adjustments to it are...

Yeah my bad about other mods. I just guessed that they also define this property before double checking. Update rules are meant for modders to quickly update their mod. Whenever...

> * I thought I did a codebase search-replace for `DeliveryBuildings` and checked why the other mods don't appear to use that name. Answer is that _TS_ is the only...

First of all, we don't have a release yet, so this change will need to go in `release-20210321` category. Your update rule is a bit overkill. It's just a simple...

Also as an unspoken rule we capitalise the first letter in commits. Just a note for the future

A bit of a different discussion, but when optimising should consider GPS's towers. Basically a tower that gives gps vision in a circle around it. I think this feature fits...

I'm not too familiar with `BlendMode` or any of the graphics code so I won't be doing that. If you want to you can create a PR for it, possibly...