Michael Smith

Results 37 comments of Michael Smith

This is essentially "fixed" when using statements after this commit: https://github.com/EngineHub/CommandHelper/commit/bd725d0a270abc11c87aee7625cbc70e4cd4c247 . As long as a semi-colon is used, there is no error. Should this be closed?

The result is the same in non-strict mode without semi-colons: using undefined variable. If in strict mode or using semi-colons, there's no issue.

Yes, it appears x_recompile_includes() does not support static analysis yet. I recommend not using that function until it is, or disabling static analysis. It should be noted that I stuck...

The lack of file order only matters for auto_includes. There is never a use for proc overriding there, so it can always be detected and have a warning. (ie. all...

To be clear, I use proc overriding in a few projects. It is useful. It is current behavior. (there could be instances in people's scripts where a file is included...

452cde8 I fixed at least one place this occurs by using the trailing data Target instead of the ClassType Target. It was more appropriate in that context anyway. ClassTypes having...

To help inform this discussion, I've actually used this to store useful maps inside proc definitions. I do not modify these maps in the proc, but because they're not deep...

I would think that with resources you wouldn't want to create a default one in the arguments anyway. With arrays it's debatable. I kind of like dynamic defaults (and I...

My default maps wouldn't break, they just wouldn't be as fast since they would have to be created every time. (What I really want is something like an immutable array...

Apparently Spigot already translates their hex code format to terminal colors when using sendMessage for ConsoleCommandSender. So we could change Static.SendMessage to use that, as long as we make sure...