Xavier Poon

Results 9 comments of Xavier Poon

Ability to open on the left

I have included feature in an updated (javascript) version: https://github.com/mui-org/material-ui/issues/11723#issuecomment-632132246

Nested MenuItem don't close when using keyboard to select

Here is a javascript solution: https://github.com/mui-org/material-ui/issues/11723#issuecomment-632132246

Cannot set property 'chosen' of undefined

What is the use of choose and unchoose? I have never found a case where setList is called with choose = true As a quick workaround I am doing: ```...

DOM-objects without an `style`-attribute can now be rendered

Please merge this change into master. I cannot render image with math without it

Cannot render markdown while using library with ReactMarkdown

Try ``` math: props => {props.value}, inlineMath: props => {props.value}, ```

Type is not a subtype of type

Yes please fix this. Quite crucial part of the package. just need the ``

[BUG] Instance of 'LinkedMap<Object?, Object?>': type 'LinkedMap<Object?, Object?>' is not a subtype of type 'String'

I am getting this also but only exists in production. For some reason when I run in release mode I don't get it this error but only get tit when...

Volume setting is ignored on IOS

I fixed it in my fork by making sure to use volumeSettings.volume in AlarmRingManager.swift: ``` if !volumeSettings.fadeSteps.isEmpty { self.fadeVolume(steps: volumeSettings.fadeSteps) } else if let fadeDuration = volumeSettings.fadeDuration { self.fadeVolume(steps: [...

Volume setting is ignored on IOS

Hello have you tried reproducing by running the example provided by this repo? Create alarm with no volume and save Observe that when the alarm rings there is still sound